Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsure about SystemAPI -> get_general_system #28

Closed
Benehiko opened this issue Dec 9, 2020 · 0 comments · Fixed by #34
Closed

Unsure about SystemAPI -> get_general_system #28

Benehiko opened this issue Dec 9, 2020 · 0 comments · Fixed by #34
Assignees
@themoosman
Labels
api-question Questions relating to the cameras APIs documentation docs and examples

Comments

@Benehiko
Copy link
Member

Benehiko commented Dec 9, 2020 •
edited

The get_general_system function does not look right, is it correct?.
https://github.com/ReolinkCameraAPI/reolink-python-api/blob/984747e1db3e8f8be4d1ea55b8faa2f96eea1b39/api/system.py#L3

Also cannot find any example responses for it #27
@Benehiko Benehiko added api-question Questions relating to the cameras APIs documentation docs and examples labels Dec 9, 2020
themoosman added a commit that referenced this issue Dec 9, 2020
@themoosman
Resolve issues #32, #33, #28
20cf272
@themoosman themoosman mentioned this issue Dec 9, 2020
Merged
@Benehiko Benehiko linked a pull request Dec 9, 2020 that will close this issue
Add JSON response samples #34
Merged
@Benehiko Benehiko closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@themoosman themoosman

Labels
api-question Questions relating to the cameras APIs documentation docs and examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add JSON response samples ReolinkCameraAPI/reolinkapipy
2 participants
@themoosman @Benehiko