Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using colorama when under windows system #26

Merged
merged 1 commit into from
Dec 16, 2016
Merged

using colorama when under windows system #26

merged 1 commit into from
Dec 16, 2016

Conversation

buaabyl
Copy link

@buaabyl buaabyl commented Dec 16, 2016

This script work fine under my linux server, but color highlight is not working under window system, If you add colorama library, the color display will be fine.

But still need to modify setup.py by the way.

@reorx
Copy link
Owner

reorx commented Dec 16, 2016

That's a good idea, we can use the extras_require directive in setup.py to add extra requirements for windows system. Then windows users could install in a way like pip install httpstat[windows] to have colorama installed.

I'll try to add some code later, thanks for the suggestion.

@reorx reorx changed the base branch from master to windows-support December 16, 2016 09:17
@reorx reorx merged commit 7d95cea into reorx:windows-support Dec 16, 2016
@reorx reorx mentioned this pull request Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants