Skip to content

Commit

Permalink
Minor comment, version update.
Browse files Browse the repository at this point in the history
  • Loading branch information
repalash committed Mar 14, 2024
1 parent c066c63 commit c01943b
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 12 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "threepipe",
"version": "0.0.23",
"version": "0.0.24",
"description": "A 3D viewer framework built on top of three.js in TypeScript with a focus on quality rendering, modularity and extensibility.",
"main": "dist/index.js",
"module": "dist/index.mjs",
Expand Down
4 changes: 2 additions & 2 deletions plugins/tweakpane-editor/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions src/three/controls/FirstPersonControls2.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {EventDispatcher, MathUtils, Object3D, Spherical, Vector3} from 'three'
import {IEvent, now, serialize} from 'ts-browser-helpers'
import {uiFolderContainer, uiInput, uiToggle} from 'uiconfig.js'
import {uiInput, uiPanelContainer, uiToggle} from 'uiconfig.js'
import {ICameraControls} from '../../core'

// eslint-disable-next-line @typescript-eslint/naming-convention
Expand All @@ -13,7 +13,8 @@ const _target = new Vector3()
// eslint-disable-next-line @typescript-eslint/naming-convention
const _changeEvent: IEvent<'change'> = {type: 'change'}

@uiFolderContainer('First Person Controls')
// todo bug - this is not showing in the UI. To test, switch to threeFirstPerson controlsMode for Default Camera in the tweakpane editor
@uiPanelContainer('First Person Controls')
export class FirstPersonControls2 extends EventDispatcher implements ICameraControls<'change'> {
readonly object: Object3D
readonly domElement: HTMLElement | Document
Expand All @@ -23,17 +24,17 @@ export class FirstPersonControls2 extends EventDispatcher implements ICameraCont
@serialize() @uiToggle() enableKeys = true

@serialize() @uiInput() movementSpeed = 1.0
@serialize() @uiInput()lookSpeed = 0.005
@serialize() @uiInput() lookSpeed = 0.005

@serialize() @uiToggle() lookVertical = true
@serialize() @uiToggle() autoForward = false

@serialize() @uiToggle() activeLook = true

@serialize() @uiToggle() heightSpeed = false
@serialize() @uiInput()heightCoef = 1.0
@serialize() @uiInput()heightMin = 0.0
@serialize() @uiInput()heightMax = 1.0
@serialize() @uiInput() heightCoef = 1.0
@serialize() @uiInput() heightMin = 0.0
@serialize() @uiInput() heightMax = 1.0

@serialize() @uiToggle() constrainVertical = false
@serialize() @uiInput() verticalMin = 0
Expand Down
2 changes: 1 addition & 1 deletion src/viewer/version.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const VERSION = '0.0.23'
export const VERSION = '0.0.24'

0 comments on commit c01943b

Please sign in to comment.