Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Connection::setStreamTimeout must support milliseconds #79

Merged
merged 1 commit into from
Jul 19, 2016
Merged

BUGFIX: Connection::setStreamTimeout must support milliseconds #79

merged 1 commit into from
Jul 19, 2016

Conversation

dfeyer
Copy link
Contributor

@dfeyer dfeyer commented Jun 30, 2016

This also refactor the Connection::getStream method to avoid code duplication

@coveralls
Copy link

coveralls commented Jun 30, 2016 •
edited

Coverage Status

Coverage decreased (-50.5%) to 37.368% when pulling 51cc009 on dfeyer:bugfix-timeout into 883311c on repejota:develop.

@coveralls
Copy link

coveralls commented Jun 30, 2016 •
edited

Coverage Status

Coverage decreased (-50.3%) to 37.566% when pulling 8a45b04 on dfeyer:bugfix-timeout into 883311c on repejota:develop.

@coveralls
Copy link

coveralls commented Jun 30, 2016 •
edited

Coverage Status

Coverage decreased (-50.3%) to 37.566% when pulling 8a45b04 on dfeyer:bugfix-timeout into 883311c on repejota:develop.

@coveralls
Copy link

coveralls commented Jun 30, 2016 •
edited

Coverage Status

Coverage decreased (-1.06%) to 86.772% when pulling 1a5249b on dfeyer:bugfix-timeout into 883311c on repejota:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.06%) to 86.772% when pulling 7a493ee on dfeyer:bugfix-timeout into 883311c on repejota:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 30, 2016 •
edited

Coverage Status

Coverage decreased (-1.06%) to 86.772% when pulling 7a493ee on dfeyer:bugfix-timeout into 883311c on repejota:develop.

@dfeyer
BUGFIX: Connection::setStreamTimeout must support milliseconds
8a3986a 
This also refactor the Connection::getStream method to avoid code duplication
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.831% when pulling 8a3986a on dfeyer:bugfix-timeout into 883311c on repejota:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 30, 2016 •
edited

Coverage Status

Coverage remained the same at 87.831% when pulling 8a3986a on dfeyer:bugfix-timeout into 883311c on repejota:develop.

@dfeyer
Copy link
Contributor Author

dfeyer commented Jul 4, 2016

@repejota If we can merge this one maybe we should release a new stable version (and raise again the client version in the connection arguments) ?

@repejota
Copy link
Owner

repejota commented Jul 5, 2016

LGTM
I'll merge this today and will release an stable version 👍

@repejota repejota self-assigned this Jul 5, 2016
@repejota repejota merged commit 14078bc into repejota:develop Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@repejota repejota

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dfeyer @coveralls @repejota