add another implementation "javanet" #152
Conversation
|
Awesome addition! Thanks! 👌 Would you mind splitting the changes into multiple commits? There are a few fixes/changes to Netty 3 and Netty 4 in this PR. |
we are going to reuse it in "javanet" module
asolntsev
force-pushed
the
javanet
branch
2 times, most recently
from
a64cd2f
to
783c950
Compare
|
@xabolcs Yes, sure. I have split the PR to few independent commits. |
But it's still possible to run with other backends in tests with gradle tasks "uitest-netty3", "uitest-netty4" etc.
.. to a single place (ServerHelper, Utils etc.)
.. as an alternative to Netty3 and Netty4. It uses Java built-in http server instead of Netty.
|
Why do the tests fail? The GitHub workers are too resource constrained and slow? They pass for me locally. 🤔 |
|
@xabolcs I don't know yet. Yes, the tests are green on my machine too. Working on it. |
it seems that 0.0.0.0 might fail on GitHub Actions (?)
because it's shorter (easier to read in logs).
|
@xabolcs Finally, I managed to fix the PR. For some reason, commit 5d4e1db0cd4e641d74e44 fixed the failing test. |
|
@xabolcs I've published version |
.. as an alternative to Netty3 and Netty4.
It uses Java built-in http server instead of Netty.