Skip to content

Commit

Permalink
Assert MemoryCache::Prune and more (#789)
Browse files Browse the repository at this point in the history
  • Loading branch information
Domiii committed Jul 2, 2023
1 parent 0384e14 commit 3dc2fc5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
7 changes: 6 additions & 1 deletion components/web_cache/browser/web_cache_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -360,19 +360,24 @@ void WebCacheManager::ClearRendererCache(
content::RenderProcessHost* host =
content::RenderProcessHost::FromID(*iter);
recordreplay::Assert(
"[RUN-1975-2264] WebCacheManager::ClearRendererCache %d %d %d %d/%zu",
"[RUN-1975-2287] WebCacheManager::ClearRendererCache A %d %d %d %d/%zu",
*iter, !!host, (int)occasion,
std::distance(renderers.begin(), iter), renderers.size());
if (host) {
// Find the mojo::Remote<WebCache> by renderer process id.
auto it = web_cache_services_.find(*iter);
recordreplay::Assert(
"[RUN-1975-2287] WebCacheManager::ClearRendererCache B %d",
it != web_cache_services_.end());
if (it != web_cache_services_.end()) {
WebCacheInfo& cache_info = it->second;
DCHECK(cache_info.service);
cache_info.service->ClearCache(occasion == ON_NAVIGATION);
}
}
}
recordreplay::Assert(
"[RUN-1975-2287] WebCacheManager::ClearRendererCache C");
}

void WebCacheManager::ReviseAllocationStrategy() {
Expand Down
3 changes: 0 additions & 3 deletions third_party/blink/renderer/platform/graphics/bitmap_image.cc
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ bool BitmapImage::CurrentFrameHasSingleSecurityOrigin() const {
}

void BitmapImage::DestroyDecodedData() {
recordreplay::Assert(
"[RUN-1975-2225] BitmapImage::DestroyDecodedData %d %u",
paint_image_id(), reset_animation_sequence_id_);
cached_frame_ = PaintImage();
NotifyMemoryChanged();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,8 @@ void MemoryCache::EvictResources() {
void MemoryCache::Prune() {
TRACE_EVENT0("renderer", "MemoryCache::prune()");

recordreplay::Assert("[RUN-1975-2287] MemoryCache::Prune");

// Cache state can vary when replaying, make sure we don't interact
// with the recording while pruning.
recordreplay::AutoDisallowEvents disallow("MemoryCache::Prune");
Expand Down

0 comments on commit 3dc2fc5

Please sign in to comment.