Support compilation cache (#713)

replayio · Jun 23, 2023 · 7a73c97 · 7a73c97
1 parent 0539d29
commit 7a73c97
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/DEPS b/DEPS
@@ -311,7 +311,7 @@ vars = {
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling V8
   # and whatever else without interference from each other.
-  'v8_revision': '9a6f7f7cbb951c2aff493b9bdac2b6896bb5aa77',
+  'v8_revision': '98c2fea170026f0635174d79816de5131833b2a1',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling swarming_client
   # and whatever else without interference from each other.

diff --git a/third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc b/third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc
@@ -140,7 +140,7 @@ V8CodeCache::GetCompileOptions(mojom::blink::V8CacheOptions cache_options,
 
   // The code cache doesn't behave correctly when scripts have record/replay
   // instrumentation.
-  if (recordreplay::IsRecordingOrReplaying("no-compile-cache")) {
+  if (recordreplay::IsRecordingOrReplaying("no-compile-cache", "V8CodeCache::GetCompileOptions")) {
     return std::make_tuple(v8::ScriptCompiler::kNoCompileOptions,
                            ProduceCacheOptions::kNoProduceCache,
                            no_cache_reason);

diff --git a/third_party/blink/renderer/modules/cache_storage/cache.cc b/third_party/blink/renderer/modules/cache_storage/cache.cc
@@ -168,7 +168,7 @@ bool ShouldGenerateV8CodeCache(ScriptState* script_state,
 
   // Bytecode varies between recording, replaying, and regular execution
   // and is not cached when recording/replaying.
-  if (recordreplay::IsRecordingOrReplaying("no-compile-cache"))
+  if (recordreplay::IsRecordingOrReplaying("no-compile-cache", "ShouldGenerateV8CodeCache"))
     return false;
 
   return true;