build: implement hack to build in vscode 2022 (#800)

replayio · Jul 5, 2023 · 8e1101c · 8e1101c
1 parent b602ba3
commit 8e1101c
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 5 deletions.
diff --git a/buildWindows.mjs b/buildWindows.mjs
@@ -3,4 +3,14 @@ import { spawnChecked, updateRepo } from "./replay_build_scripts/common.mjs";
 
 updateRepo();
 
-spawnChecked("node", ["build.js"], { stdio: "inherit" });
+// TODO(dmiller): remove this hack when we switch to the new ci system
+spawnChecked("git", ["apply", "replay_build_scripts/windows.patch"]);
+
+try {
+  spawnChecked("node", ["build.js"], { stdio: "inherit" });
+} finally {
+  spawnChecked("git", [
+    "checkout",
+    "media/audio/win/audio_low_latency_input_win.cc",
+  ]);
+}
diff --git a/media/audio/win/audio_low_latency_input_win.cc b/media/audio/win/audio_low_latency_input_win.cc
@@ -193,10 +193,6 @@ const char* EffectTypeToString(
       return "DynamicRangeCompression";
     case ABI::Windows::Media::Effects::AudioEffectType_FarFieldBeamForming:
       return "FarFieldBeamForming";
-#if _MSC_VER >= 1930 // Visual Studio 2022
-    case ABI::Windows::Media::Effects::AudioEffectType_DeepNoiseSuppression:
-      return "DeepNoise";
-#endif
   }
   return "Unknown";
 }

diff --git a/replay_build_scripts/windows.patch b/replay_build_scripts/windows.patch
@@ -0,0 +1,13 @@
+diff --git a/media/audio/win/audio_low_latency_input_win.cc b/media/audio/win/audio_low_latency_input_win.cc
+index 23372ebe4e4bf..95a7a69201875 100644
+--- a/media/audio/win/audio_low_latency_input_win.cc
++++ b/media/audio/win/audio_low_latency_input_win.cc
+@@ -193,6 +193,8 @@ const char* EffectTypeToString(
+       return "DynamicRangeCompression";
+     case ABI::Windows::Media::Effects::AudioEffectType_FarFieldBeamForming:
+       return "FarFieldBeamForming";
++    case ABI::Windows::Media::Effects::AudioEffectType_DeepNoiseSuppression:
++      return "DeepNoise";
+   }
+   return "Unknown";
+ }