Add network request data support. #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannanvijayan
force-pushed
the
kannan/run-721-chromium-netmonitor-request-body-data
branch
from
ce1be7c
to
5f7698a
Compare
|
Ok this works now, and I can see form request data coming back in the UI for a simple test case I wrote. This does NOT handle streaming request data. |
bhackett1024
approved these changes
Dec 8, 2022
kannanvijayan
force-pushed
the
kannan/run-721-chromium-netmonitor-request-body-data
branch
from
5f7698a
to
3b023f9
Compare
kannanvijayan
deleted the
kannan/run-721-chromium-netmonitor-request-body-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds network request support for form data only. I tried for a while to poke around to get streams also but it's a bit convoluted and I think I might have to wrap an existing
mojo::Remote<ChunkedData>with my ownmojo::Remotethat implements the same interface and traps info.Tested this briefly but I don't see request data showing up in the UI yet, so something is still wrong even with the non-stream request data. Still needs fixing before landing.