Assorted fixes for mac chromium #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
reviewed
Feb 6, 2023
| @@ -39,8 +39,10 @@ WaitableEvent::WaitableEvent(ResetPolicy reset_policy, | |||
| InitialState initial_state) | |||
| : policy_(reset_policy) { | |||
| // Pointer registration is needed for sorting in WaitSet.user_events_ | |||
| recordreplay::RegisterPointer("WaitableEvent", this); | |||
| record_replay_ordered_lock_id_ = recordreplay::CreateOrderedLock("WaitableEvent"); | |||
| if (!recordreplay::AreEventsDisallowed() || recordreplay::HasDivergedFromRecording()) { | |||
There was a problem hiding this comment.
I'm amazed by how little changes are needed for mac. i.e. it looks like even this cc file is mac specific
There was a problem hiding this comment.
Well, there is some other mac specific logic already in place, since we used to be able to record/replay on chrome 91 and I made sure that the mac build worked during the 108 rebase.
kannanvijayan
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/replay/issue/RUN-1285