Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on strict null checks in both prototype folders #7236

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

markerikson
Copy link
Collaborator

This PR:

  • Turns on strict: true in the tsconfig.json for both prototype folders, because APPARENTLY WE DIDN'T HAVE TS STRICT MODE ON AND THIS WAS BREAKING THINGS ARGHGHHHHGGH!

(extracted from #7205 )

@markerikson markerikson requested a review from bvaughn June 21, 2022 19:17
@vercel
Copy link

vercel bot commented Jun 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devtools ✅ Ready (Inspect) Visit Preview Jun 21, 2022 at 7:21PM (UTC)

Copy link
Collaborator

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@markerikson markerikson merged commit b69c18f into main Jun 21, 2022
@markerikson markerikson deleted the feature/FE-259-strict-ts branch June 21, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants