Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SourcesTree logic and components to TS #7365

Merged
merged 21 commits into from Jul 11, 2022
Merged

Migrate SourcesTree logic and components to TS #7365

merged 21 commits into from Jul 11, 2022

Conversation

markerikson
Copy link
Collaborator

This PR:

  • Migrates all of utils/sources-tree to TS
  • Migrates the SourcesTree/SourcesTreeItem components to TS

@markerikson markerikson requested a review from jcmorrow July 8, 2022 20:59
@vercel
Copy link

vercel bot commented Jul 8, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devtools ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 2:47PM (UTC)

@markerikson markerikson changed the title Migrate SourcesTree logic to TS Migrate SourcesTree logic and components to TS Jul 8, 2022
@qa-wolf
Copy link

qa-wolf bot commented Jul 8, 2022 •
edited

✅ QA Wolf - Deploy PR

Bubbles here: 7 tests ran, see details here.

✅ 7 passed

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

logo

46 replays were recorded for 20c401a.

image 0 Failed
image 46 Passed

View test run on Replay ↗︎

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

logo

52 replays were recorded for 20c401a.

image 0 Failed
image 52 Passed

View test run on Replay ↗︎

@markerikson
Port initial Flow types to TS
17a6cf1
@markerikson
Rename utils/url.js to TS
b9a6200
@markerikson
Migrate utils/url content to TS
ca58f85
@markerikson
Rename sources-tree/utils.js to TS
2238555
@markerikson
Migrate sources-tree/utils content to TS
f2a91f2
@markerikson
Rename sources-tree/getDirectories.js to TS
338bdd2
@markerikson
Migrate sources-tree/getDirectories content to TS
63133b4
@markerikson
Rename sources-tree/treeOrder.js to TS
ee1d54c
@markerikson
Migrate sources-tree/treeOrder content to TS
a9afc5c
@markerikson
Rename sources-tree/collapseTree.js to TS
c5b15f5
@markerikson
Migrate sources-tree/collapseTree content to TS
177bb09
@markerikson
Rename sources-tree/formatTree.js to TS
1854e7e
@markerikson
Rename sources-tree/sortTree.js to TS
dc8c8c0
@markerikson
Rename sources-tree/getURL.js to TS
f6dbf13
@markerikson
Rename sources-tree/addToTree.js to TS
5e96cfa
@markerikson
Migrate sources-tree/addToTree content to TS
0323e12
@markerikson
Rename sources-tree/updateTree.js to TS
6f216ce
@markerikson
Rename SourcesTreeItem.js to TSX
9641961
@markerikson
Migrate SourcesTreeItem content to TS
b7f23d5
@markerikson
Rename SourcesTree.js to TS
21e662e
@markerikson
Migrate SourcesTree logic to TS
877aaa0
@markerikson markerikson force-pushed the feature/FE-323-sources-tree-ts branch from 20c401a to 877aaa0 Compare July 11, 2022 14:43
@github-actions
Copy link

logo

52 replays were recorded for 877aaa0.

image 0 Failed
image 52 Passed

View test run on Replay ↗︎

@markerikson markerikson merged commit f775268 into main Jul 11, 2022
@markerikson markerikson deleted the feature/FE-323-sources-tree-ts branch July 11, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@replay-soc2 replay-soc2[bot] replay-soc2 approved these changes

@jcmorrow jcmorrow Awaiting requested review from jcmorrow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@markerikson