Fix opening two signin windows from WebChannel connection #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified this with this branch build: |
jazzdan
approved these changes
Mar 18, 2024
| registerWebChannel(localUrl); | ||
|
|
||
| function registerWebChannel(url) { | ||
| console.log("Registering WebChannel for", url); |
There was a problem hiding this comment.
I'm guessing these console logs don't end up polluting the users pane because they run in a separate browser process?
There was a problem hiding this comment.
Correct. They only log to the browser console and not the web page's console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #978 , we were adding two WebChannel listeners on
app.replay.iocausing two windows to be opened when using the app.replay.io sign in button. Only one of the two windows would work for sign in so sometimes the user would click the right one and sometimes not.The solution is to prevent adding a second listener when the
devtools.recordreplay.recordingsUrlpreference matches either of the regex domains.