Refactor monaco examples #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjduffy
force-pushed
the
refactor-monaco
branch
from
d02eb9c
to
b4752b3
Compare
jasonLaster
approved these changes
Apr 16, 2021
| for (const editor of editors) { | ||
| await page.selectOption(selectors.select, editor); | ||
| await page.waitForTimeout(1000); | ||
| } |
There was a problem hiding this comment.
haha we can always trim this back to ~5 or so editors if we need to
There was a problem hiding this comment.
Sure. My goal right now is to get everything running and reporting consistently and then revisit with an eye for the purpose of the test. The exercise of updating the tests has been helpful to acclimate to the environment and develop some reasonable abstractions.
|
Yep
…On Fri, Apr 16, 2021, 11:02 AM Ryan Duffy ***@***.***> wrote:
Merged #45 <#45>
into main.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB6EYWG7LKJPFJFIDLAVWLTJB3UJANCNFSM43ANLBDA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the two examples as actions within one example.
https://replay.io/view?id=f2340c77-aaf7-41f5-86ef-00d43c8a577e
Having trouble getting the replay to load but including the link nonetheless