Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a regular symlink to link @replayio/cypress into flake's repo #349

Merged
merged 9 commits into from
Apr 5, 2024

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Apr 4, 2024

It turns out that the simplest solution is the best...

For some reason, (I have no idea what has changed) npm link started to fail on the CI. It tried to execute prepare script in our packages/cypress (I couldn't figure out how to make it stop doing that) and failed on executing tsc there (it looked as if it was invoked with a wrong cwd or smth).

Since we already pre-build that at the bootstrap step, I just decided to use a regular symlink to bypass npm weirdness and it just works now™

Copy link

replay-io bot commented Apr 5, 2024

Status Complete ↗︎
Commit 80cc8b5
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @Andarist Andarist changed the title Test npm linking on CI Use a regular symlink to link @replayio/cypress into flake's repo Apr 5, 2024
    @Andarist Andarist marked this pull request as ready for review April 5, 2024 13:23
    Copy link
    Collaborator

    @bvaughn bvaughn left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice! 👏🏼 Thanks for hunting this down.

    @Andarist Andarist merged commit ac99802 into main Apr 5, 2024
    3 checks passed
    @Andarist Andarist deleted the test-npm-linking-on-ci branch April 5, 2024 14:00
    @ryanjduffy
    Copy link
    Contributor

    bypass npm weirdness

    I feel like this could be its own npm package ... or maybe a t-shirt ... or both ...

    Either way, thanks for the fix!!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    3 participants