Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mixpanel to Playwright #577

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Add Mixpanel to Playwright #577

merged 3 commits into from
Jul 2, 2024

Conversation

bvaughn
Copy link
Collaborator

@bvaughn bvaughn commented Jun 30, 2024

  • Reorganized Mixpanel code to be a bit easier to reason about and added some more unit tests
    • Most of the lines changed in this PR comes from this reorganization
  • Add some basic Mixpanel logging to the playwright and test-utils packages
    • Playwright specific tracking:
      • Invalid reporter config
      • Replay reporter used without Replay browser
    • Test utils tracking (also applies to Cypress)
      • Reporter error
      • Missing API key
      • Recording metadata
      • Test end
      • Test suite begin and end
      • Test suite results (including number of crashed recordings and uploaded recordings)
  • Spot test and verify that events are ending up in Mixpanel

Copy link

changeset-bot bot commented Jun 30, 2024

⚠️ No Changeset found

Latest commit: 7574459

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

replay-io bot commented Jun 30, 2024

Status Complete ↗︎
Commit 2cc57b2
Results
2 Failed
  • clicks a disappearing button
  • should fail on this test
  • 42 Passed
  • adds items
  • adds new items using a custom command
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • adds todos following the fixture
  • calls inform
  • complete all checkbox should update state when items are completed / cleared
  • gets a number
  • only gets a number
  • only gets a number
  • should allow me to add todo items
  • should allow me to clear the complete state of all items
  • should allow me to display active items
  • should allow me to display all items
  • should allow me to display completed items
  • should allow me to edit an item
  • should allow me to mark all items as completed
  • should allow me to mark items as complete
  • should allow me to un-mark items as complete
  • should append new items to the bottom of the list
  • should be hidden when there are no items that are completed
  • should cancel edits on escape
  • should clear text input field when an item is added
  • should display the correct text
  • should display the current number of todo items
  • should focus on the todo input field
  • should hide #main and #footer
  • should hide other controls when editing
  • should highlight the currently applied filter
  • should intercept postman
  • should invoke some commands that have exceptional option handling
  • should log
  • should persist its data
  • should remove completed items when clicked
  • should remove the item if an empty text string was entered
  • should respect the back button
  • should save edits on blur
  • should show #main and #footer when items added
  • should trim entered text
  • should trim text input
  • yields a number
  • @bvaughn bvaughn force-pushed the PRO-712 branch 6 times, most recently from 7a30362 to e8e54a1 Compare July 1, 2024 19:19
    @bvaughn
    Copy link
    Collaborator Author

    bvaughn commented Jul 1, 2024

    /release-pr -> 0.0.0-pr577-20240701192536

    @bvaughn bvaughn requested a review from Andarist July 1, 2024 20:18
    @bvaughn bvaughn marked this pull request as ready for review July 1, 2024 20:18
    packageName,
    packageVersion,
    }),
    mixpanelAPI.initialize({ accessToken, packageName, packageVersion }),
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    not directly related to this PR - but since the logger initialization is grouped together with the mixpanel's initialization in our test plugins it could also make sense to move that into this [...]/initialize.ts file here

    Comment on lines 442 to +444
    logger.info("OnTestSuiteBegin:NoApiKey");

    mixpanelAPI.trackEvent("test-suite.no-api-key");
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    q: couldn't we use a single naming scheme for both of those "loggers"?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yes we could but I don't know if there's value in doing that. They're tracking different things. Sometimes they'll line up (like here) but often they won't. Standardizing on names is work/effort.

    @bvaughn bvaughn merged commit 4624764 into main Jul 2, 2024
    7 checks passed
    @bvaughn bvaughn deleted the PRO-712 branch July 2, 2024 13:16
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants