Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: "Mounting Type" Error #191

Closed
TWM617 opened this issue May 4, 2023 · 21 comments
Closed

[Bug]: "Mounting Type" Error #191

TWM617 opened this issue May 4, 2023 · 21 comments
Assignees
@replaysMike
Labels
bug Something isn't working
Milestone
v2.5.6

Comments

@TWM617
Copy link

TWM617 commented May 4, 2023

Binner version

v2.5.4

Operating System

Windows 10 64

Describe the bug and the steps to reproduce it

When I scan the following barcode, the mounting type is not set so I cannot save the part in inventory and when I select the proper type, SMD, then leave the textbox it reverts back to "Mounting Type". Scans also aren't picking up the quantity.
IMG_1343

Would you like to attach your appsetings.json configuration?

No response

Screenshots or Videos (Optional, but they help!)

No response

Are you able to contribute a PR? (No is ok!)

None
@TWM617 TWM617 added the bug Something isn't working label May 4, 2023
@replaysMike replaysMike self-assigned this May 4, 2023
@TWM617
Copy link
Author

TWM617 commented May 10, 2023

This continues to be a showstopper for me. I can't add any parts to inventory via scanning. I went to Settings and increased the buffer time to 200 mS and the test scan now picks up the quantity but the scan to add to inventory still shows just a quantity of 1. Also the mounting type still cannot be set and because of that I can't save the part to inventory.

BTW - I am willing to ship you my scanner so you can use it for debugging if that helps since I am stuck and cannot proceed until this problem is fixed.

@replaysMike
Copy link
Owner

sorry I haven't been able to focus on this yet, was tied up with a large feature. I'll take a look into this now and see if I can repro and address it

@replaysMike
Copy link
Owner

yup you're right, it's doing exactly that. It's not related to the barcode scan itself, these are inventory page bugs related to a complex performance update for the page I've been struggling with.

Fix coming out shortly.

@replaysMike
Copy link
Owner

neat - first time I've seen this. This part comes from DigiKey as having a mounting type of both Surface Mount and Through Hole. Not sure how a part can have both, but apparently DigiKey thinks so!

@replaysMike
Copy link
Owner

replaysMike commented May 11, 2023 •
edited

fixed in v2.5.6 which should be out shortly.

@replaysMike replaysMike added this to the v2.5.6 milestone May 11, 2023
@replaysMike
Copy link
Owner

Let me know if v2.5.6 fixes your issue

@TWM617
Copy link
Author

TWM617 commented May 11, 2023 via email

@replaysMike
Copy link
Owner

replaysMike commented May 11, 2023 via email

@replaysMike
Copy link
Owner

I haven't been able to repro yet, but I'm also checking with others on Discord to see if anyone else is experiencing this

@replaysMike replaysMike reopened this May 12, 2023
@TWM617
Copy link
Author

TWM617 commented May 12, 2023 via email

@TWM617
Copy link
Author

TWM617 commented May 12, 2023 via email

@TWM617
Copy link
Author

TWM617 commented May 12, 2023

For some reason the image I attached to the email didn't show. Here is what I am seeing when trying to start the Binner service:
Ashampoo_Snap_Friday, May 12, 2023_08h48m27s_001_

@replaysMike
Copy link
Owner

ok thanks, I asked on Discord and no one else seems to be having issues so we at least know the issue is isolated to your installation. Can you check the log file in C:\Binner\Binner.log and C:\Binner\Binner.Microsoft.log ? There may be a clue in there as to what the error is

@TWM617
Copy link
Author

TWM617 commented May 12, 2023 via email

@replaysMike
Copy link
Owner

ah that should be an easy fix. It looks like Arrow = Enabled, but has no API key specified. Configuration validation was added to the service startup, to prevent issues when using Binner in a docker container.

If you have any APIs that are enabled but not configured, disabling them should fix the problem. I will need to consider whether that should be considered an error condition or not.

@replaysMike
Copy link
Owner

btw, to do that since you can't do it in the UI, is just edit your C:\Program Files\Binner\appsettings.json file and set "Enabled" = false for the problem setting in the "Integrations" section.

"Integrations": {
      "Arrow": {
        "Enabled": false,
        "ApiKey": "",
        "Username": "",
        "ApiUrl": "https://api.arrow.com"
      },
    },

@TWM617
Copy link
Author

TWM617 commented May 13, 2023 via email

@TWM617
Copy link
Author

TWM617 commented May 13, 2023 via email

@TWM617
Copy link
Author

TWM617 commented May 13, 2023

After making this change, Binner now runs and the original problem reported is now fixed. I consider this issue closed.

@TWM617 TWM617 closed this as completed May 13, 2023
@replaysMike
Copy link
Owner

oh wow - you did however reveal an unexpected bug. With the Arrow section missing it should have been disabled (all missing integrations should be) but there is a code level default that sets it to true. That isn't correct and has been changed - thanks for spotting this!

@replaysMike
Copy link
Owner

I think I should also spend some time writing a way to merge new configuration settings that are introduced. Your configuration probably predates these newer settings (from a few months ago), so any new configurations won't automatically be inserted into your config (because its kinda complex to implement, but I think it's time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@replaysMike replaysMike

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.5.6
Development

No branches or pull requests
2 participants
@replaysMike @TWM617