Skip to content

Commit

Permalink
Update VSCode workspace settings (#1545)
Browse files Browse the repository at this point in the history
* Update code actions on save

Signed-off-by: Mattt Zmuda <mattt@replicate.com>

* Update setting key to ruff.lint.args

Signed-off-by: Mattt Zmuda <mattt@replicate.com>

* Remove python.linting settings

All settings starting with "python.linting." are deprecated and can be removed from settings.

Signed-off-by: Mattt Zmuda <mattt@replicate.com>

* Use vscode.json-language-features to format JSON

Signed-off-by: Mattt Zmuda <mattt@replicate.com>

* Remove prettier and black from recommended extensions

Signed-off-by: Mattt Zmuda <mattt@replicate.com>

---------

Signed-off-by: Mattt Zmuda <mattt@replicate.com>
  • Loading branch information
mattt committed May 23, 2024
1 parent 4e48c28 commit fe0d2db
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
2 changes: 0 additions & 2 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"recommendations": [
"charliermarsh.ruff",
"esbenp.prettier-vscode",
"golang.go",
"ms-python.black-formatter",
"ms-python.python",
"ms-python.vscode-pylance"
]
Expand Down
24 changes: 14 additions & 10 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,27 +13,31 @@
"go.lintTool": "golangci-lint",
"go.formatTool": "goimports",
"go.testOnSave": true,
"gopls": { "formatting.local": "github.com/replicate/cog" },
"gopls": {
"formatting.local": "github.com/replicate/cog"
},
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
"editor.defaultFormatter": "vscode.json-language-features"
},
"[jsonc]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
"editor.defaultFormatter": "vscode.json-language-features"
},
"[python]": {
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll": true,
"source.organizeImports": true
"source.fixAll": "explicit",
"source.organizeImports": "explicit"
},
"editor.defaultFormatter": "charliermarsh.ruff"
},
"python.languageServer": "Pylance",
"python.testing.pytestArgs": ["-vvv", "python"],
"python.testing.pytestArgs": [
"-vvv",
"python"
],
"python.testing.unittestEnabled": false,
"python.testing.pytestEnabled": true,
"python.formatting.provider": "black",
"python.linting.mypyEnabled": true,
"python.linting.mypyArgs": ["--show-column-numbers", "--no-pretty"],
"ruff.args": ["--config=pyproject.toml"]
"ruff.lint.args": [
"--config=pyproject.toml"
]
}

0 comments on commit fe0d2db

Please sign in to comment.