Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If you hit Ctrl-C when running cog predict, model is left running in background #226

Closed
bfirsh opened this issue Sep 3, 2021 · 0 comments
Closed

If you hit Ctrl-C when running cog predict, model is left running in background #226

bfirsh opened this issue Sep 3, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bfirsh
Copy link
Member

bfirsh commented Sep 3, 2021 •
edited
Loading

We should catch the signal and stop/kill the container.

As a nice to have or future bit of work: Could use similar stop/kill behavior to docker-compose up here. The first Ctrl-C gracefully waits for it to finish, the second SIGTERMs it.
@bfirsh bfirsh added the help wanted Extra attention is needed label Sep 3, 2021
@bfirsh bfirsh mentioned this issue Oct 12, 2021
Closed
@bfirsh bfirsh added the good first issue Good for newcomers label Jan 5, 2022
@bfirsh bfirsh closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bfirsh