allow setup(self, weights: str) #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technillogue
force-pushed
the
syl/allow-str-setup-weight-type
branch
from
81f9659
to
92cda9d
Compare
anotherjesse
reviewed
Mar 5, 2024
python/cog/predictor.py
Outdated
| @@ -85,6 +85,9 @@ def run_setup(predictor: BasePredictor) -> None: | |||
| elif weights_type == CogPath: | |||
| # TODO: So this can be a url. evil! | |||
| weights = cast(CogPath, CogPath.validate(weights_url)) | |||
| # allow people to download weights themselves | |||
| elif weights_type == str: | |||
| weights = weights_url | |||
| else: | |||
| raise ValueError( | |||
| f"Predictor.setup() has an argument 'weights' of type {weights_type}, but only File and Path are supported" | |||
There was a problem hiding this comment.
should we add str to the error message 🤷
|
lgtm except the test is failing |
|
something changed in one our deps and now the test is flaking idk |
anotherjesse
force-pushed
the
syl/allow-str-setup-weight-type
branch
from
b8fd869
to
0c30305
Compare
Signed-off-by: technillogue <technillogue@gmail.com>
Signed-off-by: technillogue <technillogue@gmail.com>
technillogue
force-pushed
the
syl/allow-str-setup-weight-type
branch
from
0c30305
to
78bc7e3
Compare
|
I reran the tests a few times and it worked. I'll debug why tests are flaking in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the behavior of cog.Path and cog.File as setup weights argument is inconsistent with how it works in predict. allowing str is a way out until that's fixed properly