Update install script instructions #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
See fish-shell/fish-shell#5181 Signed-off-by: Mattt Zmuda <mattt@replicate.com>
|
Also, I'm hard-wired to notice "OS X", so I updated that to "macOS". |
jessie-young
pushed a commit
that referenced
this pull request
Jun 21, 2024
* OS X -> macOS Signed-off-by: Mattt Zmuda <mattt@replicate.com> * Update install script instructions to run interactively See fish-shell/fish-shell#5181 Signed-off-by: Mattt Zmuda <mattt@replicate.com> --------- Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1558
Trying this out myself, I noticed that it wasn't being run interactively. To make that work, you need to redirect the source directly into a
shprocess. Piped execution doesn't support interactivity.This PR updates to use process substitution syntax. As discussed in fish-shell/fish-shell#5181, fish (my preferred shell) uses a different syntax, so I added special instructions for that. I also removed instructions for
fetch, because I thinkwgetandcurlcover the vast majority of use cases.