add support for optionally requesting, receiving, and validating webhooks #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeke
changed the title
zeke
commented
May 13, 2024
| return NextResponse.json({ detail: "Webhook received (but not validated)" }, { status: 200 }); | ||
| } | ||
|
|
||
| const webhookIsValid = await validateWebhook(request.clone(), secret); |
There was a problem hiding this comment.
I'm doing this request.clone() business here because you can only read the request body once in Next.js API routes. Without this change, you'll get TypeError: Body is unusable when calling request.json() after validation.
@mattt what do you think of this?
zeke
force-pushed
the
webhook-validation-on-app-router
branch
from
908d672
to
beba5b8
Compare
Update README.md Update README.md move the iguana Update README.md rearrange webhooks docs Update README.md
zeke
force-pushed
the
webhook-validation-on-app-router
branch
from
beba5b8
to
db584f4
Compare
deepfates
approved these changes
May 13, 2024
Just for dev. Good shout. Updated in 863a91a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #99 with an updated approach using Next.js app router with proper Request and Response objects.
Docs: https://github.com/replicate/getting-started-nextjs/tree/webhook-validation-on-app-router#webhooks
To Do
reqvsRequestshenanigans go away?