-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the node protocol from the require statement #250
Conversation
Urgh, this is probably a no-go too, if we remove the
|
ab30893
to
2e68c8d
Compare
@@ -0,0 +1,14 @@ | |||
{ | |||
"name": "replicate-next", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aron Thanks for taking the time to add an integration test for Next.js!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this. Thanks so much for your work on this. Here's hoping that this will resolve the issues folks were having with standard library imports.
This should improve the situation for certain JavaScript bundlers in the ecosystem which do not like the `node:crypto` require statement.
2e68c8d
to
6ae67a2
Compare
This should improve the situation for certain JavaScript bundlers in the ecosystem which do not like the
node:crypto
require statement, see #225 and #243.