Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of optional chaining in client #253

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

mattt
Copy link
Member

@mattt mattt commented May 2, 2024

Despite the optional chaining (?.) operator being supported in Node >= 14, I continue to see anecdotal reports from users of other libraries encountering SyntaxError: Unexpected token '.', even when targeting Node.js 20.

With all the weird, frustrating compatibility issues throughout the JS ecosystem, I take some comfort in having some control that I can exercise over this one. (Maybe I'm paranoid, but hey — at least I'm consistent about it?)

@mattt mattt merged commit 082a0f8 into main May 2, 2024
16 checks passed
@mattt mattt deleted the mattt/no-optional-chaining branch May 2, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant