Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document fine-tuning and clean up trainings API #240

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

mattt
Copy link
Member

@mattt mattt commented Feb 4, 2024

This PR improves the experience of using Replicate's training APIs by making the following changes:

  • Adding a section to the README discussing how to create a training
  • Updating the Training.cancel instance method to mutate the caller, matching the behavior of prediction.reload
  • Adding test coverage for async variants of training namespace methods

This PR also makes corresponding changes to predictions APIs to fix a few discrepancies that were found along the way.

Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
This matches the behavior of reload

Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Add test coverage for trainings.cancel

Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt mattt requested a review from zeke February 4, 2024 11:14
README.md Outdated Show resolved Hide resolved
Copy link
Member

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I left a tiny suggestion, but this looks great. 👍🏼

Co-authored-by: Zeke Sikelianos <zeke@sikelianos.com>
@mattt mattt merged commit bd2c225 into main Feb 5, 2024
8 checks passed
@mattt mattt deleted the mattt/prefer-model-version-training branch February 5, 2024 17:01
GothReigen pushed a commit that referenced this pull request Feb 9, 2024
This PR improves the experience of using Replicate's [training
APIs](https://replicate.com/docs/reference/http#trainings.create) by
making the following changes:

- Adding a section to the README discussing how to create a training
- Updating the `Training.cancel` instance method to mutate the caller,
matching the behavior of `prediction.reload`
- Adding test coverage for async variants of training namespace methods

This PR also makes corresponding changes to predictions APIs to fix a
few discrepancies that were found along the way.

---------

Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: Zeke Sikelianos <zeke@sikelianos.com>
GothReigen pushed a commit that referenced this pull request Mar 11, 2024
This PR improves the experience of using Replicate's [training
APIs](https://replicate.com/docs/reference/http#trainings.create) by
making the following changes:

- Adding a section to the README discussing how to create a training
- Updating the `Training.cancel` instance method to mutate the caller,
matching the behavior of `prediction.reload`
- Adding test coverage for async variants of training namespace methods

This PR also makes corresponding changes to predictions APIs to fix a
few discrepancies that were found along the way.

---------

Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Co-authored-by: Zeke Sikelianos <zeke@sikelianos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants