Add support for deployments endpoints #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
force-pushed
the
mattt/deployments-endpoints
branch
from
88c03a5
to
21dd8cd
Compare
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
mattt
force-pushed
the
mattt/deployments-endpoints
branch
from
21dd8cd
to
308b15c
Compare
mattt
added a commit
that referenced
this pull request
Mar 21, 2024
#258 added fields to the `Deployment` model provided by the new `deployments.{get,list,update}` endpoints. However, those were implemented against a version of the OpenAPI specification that disagreed with the actual API responses. Specifically, the `min_instances` and `max_instances` properties were listed as subproperties of a `scaling` object rather than direct fields. The result — as reported in #270 — was Pydantic validation errors like this: ``` raise validation_error pydantic.v1.error_wrappers.ValidationError: 1 validation error for Deployment current_release -> configuration -> scaling field required (type=value_error.missing)" ``` This PR updates the `Deployment` model to correctly locate `min_instances` and `max_instances` as properties of `current_release.configuration`. Signed-off-by: Mattt Zmuda <mattt@replicate.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #247
See https://replicate.com/docs/reference/http