Warning at multistage build

[AuthorProxy]

Gives next warnings dockerfilelint:
15:1 warning dockerfilelint: Clarity Base images should specify a tag to use.
21:1 warning dockerfilelint: Clarity Base images should specify a tag to use.
26:1 warning dockerfilelint: Clarity Base images should specify a tag to use.

Where should I put this tag?

# docker --host=:3000 build -t spa .

# ---- Base image ----
FROM node:alpine AS base

LABEL version="1.0"
LABEL description="HRketing SPA application"
LABEL maintainer="Alex Kostyukov <kostyukov@itopcase.ru>"

RUN apk --no-cache --update add git
WORKDIR /usr/src/deps
COPY package*.json ./

# ---- Dependencies ----
FROM base AS dependencies
RUN npm set progress=false && npm config set depth 0
RUN npm install --loglevel=error --only=production --prefix node_modules_production
RUN npm install --loglevel=error

# ---- Linters ----
FROM dependencies AS test
COPY . .
RUN npm run lint

# ---- Release ----
FROM base AS release

ARG NODE_ENV=production
ENV NODE_ENV=$NODE_ENV

WORKDIR /usr/src/app
COPY --from=dependencies /usr/src/deps/node_modules_production ./node_modules
COPY . .
EXPOSE 3000
CMD ["npm", "run", "deploy"]

[AmauryOrtega]

@AuthorProxy This warning appears because you don't specify the tag on the FROM statements.
An example for a multistage build that doesn't show those warnings:

FROM node:8.4.0-slim as clientbuilder
WORKDIR /app
COPY src/main/frontend .
RUN yarn
RUN npm run build

FROM openjdk:8u141-jdk-slim as serverbuilder
WORKDIR /app
COPY . .
COPY --from=clientbuilder /app/dist /app/src/main/resources/static
RUN ./gradlew build

FROM openjdk:8-jre-alpine
ENV artifact app-0.0.1.jar
WORKDIR /app
COPY --from=serverbuilder /app/build/libs/${artifact} /app
EXPOSE 8080
ENTRYPOINT ["sh", "-c"]
CMD ["java -jar ${artifact}"]

In this case, the warning that appears are:

• Line 8: First Command Must Be FROM (Possible Bug)
• Line 15: First Command Must Be FROM (Possible Bug)

This is expected since there is no multistage support.

[darkvertex]

Found this issue after discovering there's no multistage support.

For anyone that needs such a thing, consider the alternative linter hadolint.

[AmauryOrtega]

@darkvertex Thanks!. The multistage Dockerfile I used as an example before shows no warnings on the online version of hadolint.

[SimonHeimberg]

There are two online checkers using this tool:

• https://www.fromlatest.io/#/ , the original one, which is outdated
• http://www.dockerfilelint.com/#/ , which uses a newer version of this tool. It supports multistage dockerfiles

But the other problem:
Both ask for a tag for line 15 (FROM base AS dependencies), which does not make sense (at least probably) because base is defined in the dockerfile. This also happens on version 1.5.0 running locally. The alternative hadolint does not have this problem.

[AmauryOrtega]

@SimonHeimberg I checked the Dockerfile posted by @AuthorProxy and the one I posted as an example in http://www.dockerfilelint.com and noticed that the line FROM base AS dependencies gives a warning because of the FROM <any_image>:<tag> is correctly using the image base but it doesn't have a tag associated to it.

dockerfilelint must be thinking that base is a published image and using the latest tag (assumed because the tag is not present) is not recommended.

The bug could be summarized into: When reusing stages with the FROM directive in a multistage Dockerfile, dockerfilelint gives a false positive warning for not having a tag associated to it.

[Aylr]

@AmauryOrtega Thanks for this nice summary. I can confirm your findings.