CLI support for stdin #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good |
marccampbell
added a commit
that referenced
this pull request
Mar 3, 2016
Bumping major semver because of PR #12
|
🤘 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of PR #11 (and fixes #10) such that the CLI can now read from:
A file, given as file name argument (previously existing)
Any contents given as an argument (courtesy of @marccampbell)
stdin, either piped to the bin or entered when bin is executed without any arguments
This PR also allows this package to be installed globally (
npm i -g dockerfilelint) and run as the executable bindockerfilelint(can't believe I didn't notice this before).Since this PR changes how the bin behaves when no arguments are given, it should probably constitute a semver major bump.