Use config.toml as default config file if --toml is passed (Closes #7) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horgix
changed the title
Horgix
force-pushed
the
toml-auto-config-file
branch
from
08531be
to
ec53f2b
Compare
|
Ping? I know it's been 2 years but I'm cleaning up my opened PR 🙂 |
|
Hey, some activity! Still would welcome any feedback on this PR, and will adapt as needed 🙂 |
|
I guess that after 5 years there isn't much hope to see this merged, and am therefore closing the PR. Good luck with the future of the project and its maintenance! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing #7 and being concerned by it too (not that much of a big deal to pass
--config config.tomlthough), I took the opportunity to improve default config format depending on the--tomloption. However, this forces to stop using thecommanderdefault.In the absence of a
--configoption, it will default to./config.yamlas it used to do. If--tomlis passed however, it will default to./config.toml. In any case, it is still overrideable by the--config [value]parameter.The implementation could probably be a better one, feel free to reject it if it's not good enough 😉