Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional cephfs #1511

Merged
merged 1 commit into from
Apr 23, 2021
Merged

optional cephfs #1511

merged 1 commit into from
Apr 23, 2021

Conversation

laverya
Copy link
Member

@laverya laverya commented Apr 22, 2021

No description provided.

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-9cebaa8-rook-1.4.9-k8s-docker

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-cb8b192-rook-1.4.9-k8s-docker

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-fd4b0eb-rook-1.4.9-k8s-docker

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-de1dcd1-rook-1.4.9-k8s-docker

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-0781b0a-rook-1.4.9-k8s-docker

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-ae2db07-rook-1.4.9-k8s-docker

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-25b1886-rook-1.4.9-k8s-docker

@laverya laverya force-pushed the laverya/rook-shared-fs-optional branch from aa98228 to 5cd8354 Compare April 22, 2021 20:59
@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-703a469-rook-1.4.9-k8s-docker

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-efa46d6-rook-1.5.9-k8s-docker https://testgrid.kurl.sh/run/pr-1511-efa46d6-rook-1.4.9-k8s-docker

@laverya laverya requested a review from emosbaugh April 22, 2021 21:35
emosbaugh
emosbaugh requested changes Apr 22, 2021
View reviewed changes
Copy link
Member

@emosbaugh emosbaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to make kurlkinds

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-59b110f-rook-1.5.9-k8s-docker https://testgrid.kurl.sh/run/pr-1511-59b110f-rook-1.4.9-k8s-docker

emosbaugh
emosbaugh requested changes Apr 22, 2021
View reviewed changes
addons/rook/template/base/install.sh Outdated
insert_resources "$dst/kustomization.yaml" filesystem.yaml
insert_patches_strategic_merge "$dst/kustomization.yaml" patches/cephfs-storageclass.yaml
insert_patches_strategic_merge "$dst/kustomization.yaml" patches/filesystem.yaml
cat << EOF >> "$dst/kustomization.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems brittle? is it possible to use function insert_patches_(Json6902)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not yet have such a function, though I can add one

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-06b0a0f-rook-1.5.9-k8s-docker https://testgrid.kurl.sh/run/pr-1511-06b0a0f-rook-1.4.9-k8s-docker

@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-4e59cc6-rook-1.5.9-k8s-docker https://testgrid.kurl.sh/run/pr-1511-4e59cc6-rook-1.4.9-k8s-docker

@laverya
Copy link
Member Author

laverya commented Apr 23, 2021

to clarify, I will remove the duplicate insert_patches_json_6902 function from the addon directory before merging - that's just needed for testgrid

@laverya laverya force-pushed the laverya/rook-shared-fs-optional branch from 044d6f9 to c062255 Compare April 23, 2021 01:08
@replicatedbot
Copy link
Collaborator

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-1511-15206e5-rook-1.5.9-k8s-docker https://testgrid.kurl.sh/run/pr-1511-15206e5-rook-1.4.9-k8s-docker

@laverya laverya merged commit 49c4b21 into master Apr 23, 2021
@laverya laverya mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emosbaugh emosbaugh emosbaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laverya @replicatedbot @emosbaugh