Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support bundle spec to openebs addon #5023

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Jan 5, 2024

What this PR does / why we need it:

Whenever openebs addon is installed as part of kURL, ensure a support bundle spec is installed in the cluster as well

Which issue(s) this PR fixes:

Fixes sc-96000

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Install an openebs support bundle spec whenever openebs addon is added to a kURL spec

Does this PR require documentation?

@banjoh banjoh added the type::feature An enhancement to an existing add on or feature label Jan 5, 2024
@banjoh banjoh requested a review from a team as a code owner January 5, 2024 20:00
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Comment on lines 194 to 195
# install troubleshoot spec
render_yaml_file_2 "$src/tmpl-troubleshoot.yaml" | kubectl apply -f -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite the idiom we normally use, but it'll work
(I would normally render it to a file in $dst, and then include it in the kustomization)

laverya
laverya previously approved these changes Jan 5, 2024
@banjoh banjoh added type::improvement and removed type::feature An enhancement to an existing add on or feature labels Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

@laverya laverya merged commit 921ea13 into main Jan 10, 2024
16 of 18 checks passed
@laverya laverya deleted the em/openebs-troubleshoot-spec branch January 10, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants