Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd drop-in to set checksum offloading off on flannel iface #5041

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

adamancini
Copy link
Member

@adamancini adamancini commented Jan 18, 2024

What this PR does / why we need it:

Add a systemd service file that turns tcp checksum offloading OFF when it sees that the vmware VMXNET3 driver is in use

Which issue(s) this PR fixes:

Fixes #

https://app.shortcut.com/replicated/story/91846/hostpreflight-detect-if-host-nic-uses-vmxnet3-driver-from-vmware-and-if-so-warn-about-vxlan-checksum-offloading

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?


Users of VMWare clusters using the VMXNET3 NIC driver will see a new systemd .service file included that disables tcp checksum offloading on the flannel interface.  This fixes an issue we have seen with dropped packets under certain combinations of VMWare NIC and cluster configurations. 

Does this PR require documentation?

NONE

@adamancini adamancini added type::feature An enhancement to an existing add on or feature echoes/effort: S Low effort changes (M * 0.5) flannel peer-review-needed Add label to PRs that need a peer-review from the Replicated Docs team labels Jan 19, 2024
@adamancini adamancini marked this pull request as ready for review January 19, 2024 01:16
@adamancini adamancini requested a review from a team as a code owner January 19, 2024 01:16
@laverya laverya merged commit ffae828 into replicatedhq:main Feb 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/effort: S Low effort changes (M * 0.5) flannel peer-review-needed Add label to PRs that need a peer-review from the Replicated Docs team type::feature An enhancement to an existing add on or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants