bug: does not attempt online install if unnecessary #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if all dependency packages are already installed on the system we don't need to try to go and fetch them online. this pr disables all repos other than the local kurl one if all dependencies were already installed.
laverya
reviewed
Apr 29, 2024
scripts/common/host-packages.sh
Outdated
Comment on lines
282
to
294
| if [ -n "$KURL_USE_RHEL9_REMOTE_YUM_REPOS" ] ; then | ||
| if [[ "${packages[*]}" == *"containerd.io"* ]] ; then | ||
| yum install --allowerasing -y "${packages[@]}" | ||
| else | ||
| yum install -y "${packages[@]}" | ||
| fi | ||
| else | ||
| yum install -y "${packages[@]}" | ||
| if [[ "${packages[*]}" == *"containerd.io"* ]] ; then | ||
| yum install --disablerepo=* --enablerepo="$reponame" --allowerasing -y "${packages[@]}" | ||
| else | ||
| yum install --disablerepo=* --enablerepo="$reponame" -y "${packages[@]}" | ||
| fi | ||
| fi |
There was a problem hiding this comment.
Instead of adding this if block, can we pass an env var that either includes the --disablerepo=* flag or not?
There was a problem hiding this comment.
Let me know if this is what you meant.
laverya
approved these changes
Apr 29, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-103780/kurl-still-tries-to-install-containerd-on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
if all dependency packages are already installed on the system we don't need to try to go and fetch them online. this pr disables all repos other than the local kurl one if all dependencies were already installed.
Which issue(s) this PR fixes:
Fixes #103780
Does this PR introduce a user-facing change?