fix detecting private images in Github's Docker Registry (#2012)

replicatedhq · Jul 28, 2021 · 00a1416 · 00a1416
1 parent 71e37dd
commit 00a1416
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/image/builder.go b/pkg/image/builder.go
@@ -626,6 +626,11 @@ func isLoginRequired(err error) bool {
 			if strings.Contains(cause.Error(), "invalid status code from registry 403") {
 				return true
 			}
+			// GitHub's Docker registry (which used the namespace docker.pkg.github.com) could return "denied" as the error message
+			// in some cases when the request is unauth'ed or has invalid credentials.
+			if cause.Error() == "denied" {
+				return true
+			}
 			return false
 		}
 	}