fix kotsadm web tests in github action (#892)

replicatedhq · Jul 31, 2020 · 91a8839 · 91a8839
1 parent 59c870a
commit 91a8839
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/.github/workflows/build-test.yaml b/.github/workflows/build-test.yaml
@@ -102,10 +102,10 @@ jobs:
 
       - run: chmod +x bin/kots
 
-
       - uses: actions/setup-node@v1
         with:
           node-version: '10.x'
+
       - name: setup testIM
         run: npm i -g @testim/testim-cli
         shell: bash

diff --git a/.github/workflows/kotsadm.yaml b/.github/workflows/kotsadm.yaml
@@ -134,15 +134,23 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v2
+
+    - name: Setup Node.js environment
+      uses: actions/setup-node@v2.1.1
+      with:
+        node-version: '10'
+
+    - name: Install cross-env
+      run: npm i -g cross-env
+      shell: bash
 
     - name: Test web
       env:
         PACT_BROKER_USERNAME: ${{ secrets.PACT_BROKER_USERNAME }}
         PACT_BROKER_PASSWORD: ${{ secrets.PACT_BROKER_PASSWORD }}
       run: |
-        # TODO: Remove '|| true' when web test works
-        make -C kotsadm/web deps test || true
-        yarn run publish:pact || true
+        make -C kotsadm/web deps test publish-pact
+
       # TODO: migrate retry logic for pacts
       # retry:
       #   automatic:

diff --git a/kotsadm/web/Makefile b/kotsadm/web/Makefile
@@ -13,6 +13,10 @@ endif
 deps:
 	yarn --silent --frozen-lockfile
 
+.PHONY: publish-pact
+publish-pact:
+	yarn run publish:pact
+
 .PHONY: clean
 clean:
 	rm -rf node_modules