Merge pull request #1066 from replicatedhq/divolgin/restic

Fix incplete snapshot error after settings are changed

kotsadm/pkg/handlers/snapshots.go

@@ -303,6 +303,13 @@ func UpdateGlobalSnapshotSettings(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	if err := snapshot.ResetResticRepositories(); err != nil {
+		logger.Error(err)
+		globalSnapshotSettingsResponse.Error = "failed to try to reset restic repositories"
+		JSON(w, 500, globalSnapshotSettingsResponse)
+		return
+	}
+
 	// most plugins (all?) require that velero be restared after updating
 	if err := snapshot.RestartVelero(); err != nil {
 		logger.Error(err)

kotsadm/pkg/snapshot/backup.go

@@ -12,12 +12,12 @@ import (
 	"github.com/pkg/errors"
 	apptypes "github.com/replicatedhq/kots/kotsadm/pkg/app/types"
 	"github.com/replicatedhq/kots/kotsadm/pkg/downstream"
-	"github.com/replicatedhq/kots/pkg/kotsutil"
 	"github.com/replicatedhq/kots/kotsadm/pkg/logger"
 	"github.com/replicatedhq/kots/kotsadm/pkg/render"
 	"github.com/replicatedhq/kots/kotsadm/pkg/snapshot/types"
 	"github.com/replicatedhq/kots/kotsadm/pkg/store"
 	kotstypes "github.com/replicatedhq/kots/pkg/kotsadm/types"
+	"github.com/replicatedhq/kots/pkg/kotsutil"
 	velerov1 "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
 	veleroclientv1 "github.com/vmware-tanzu/velero/pkg/generated/clientset/versioned/typed/velero/v1"
 	velerolabel "github.com/vmware-tanzu/velero/pkg/label"

kotsadm/pkg/snapshot/store.go

@@ -818,3 +818,37 @@ func Redact(store *types.Store) error {
 
 	return nil
 }
+
+func ResetResticRepositories() error {
+	// ResticRepositories store the previous snapshot location which breaks volume backup when location changes.
+	cfg, err := config.GetConfig()
+	if err != nil {
+		return errors.Wrap(err, "failed to get cluster config")
+	}
+
+	storageLocation, err := FindBackupStoreLocation()
+	if err != nil {
+		return errors.Wrap(err, "failed to find backupstoragelocations")
+	}
+
+	veleroClient, err := veleroclientv1.NewForConfig(cfg)
+	if err != nil {
+		return errors.Wrap(err, "failed to create clientset")
+	}
+
+	repos, err := veleroClient.ResticRepositories(storageLocation.Namespace).List(context.TODO(), metav1.ListOptions{
+		LabelSelector: "velero.io/storage-location=default",
+	})
+	if err != nil {
+		return errors.Wrap(err, "failed to list resticrepositories")
+	}
+
+	for _, repo := range repos.Items {
+		err := veleroClient.ResticRepositories(storageLocation.Namespace).Delete(context.TODO(), repo.Name, metav1.DeleteOptions{})
+		if err != nil {
+			return errors.Wrapf(err, "failed to delete resticrepository %s", repo.Name)
+		}
+	}
+
+	return nil
+}