close opened files (#2241)

replicatedhq · Oct 12, 2021 · bec7c20 · bec7c20
1 parent 7937a70
commit bec7c20
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/pkg/store/kotsstore/supportbundle_store.go b/pkg/store/kotsstore/supportbundle_store.go
@@ -295,6 +295,7 @@ func (s *KOTSStore) CreateSupportBundle(id string, appID string, archivePath str
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to open archive file")
 	}
+	defer f.Close()
 
 	outputPath := filepath.Join("supportbundles", id, "supportbundle.tar.gz")
 	err = filestore.GetStore().WriteArchive(outputPath, f)
@@ -391,6 +392,7 @@ func (s *KOTSStore) UploadSupportBundle(id string, archivePath string, marshalle
 	if err != nil {
 		return errors.Wrap(err, "failed to open archive file")
 	}
+	defer f.Close()
 
 	outputPath := filepath.Join("supportbundles", id, "supportbundle.tar.gz")
 	err = filestore.GetStore().WriteArchive(outputPath, f)

diff --git a/pkg/store/kotsstore/version_store.go b/pkg/store/kotsstore/version_store.go
@@ -211,6 +211,7 @@ func (s *KOTSStore) CreateAppVersionArchive(appID string, sequence int64, archiv
 	if err != nil {
 		return errors.Wrap(err, "failed to open archive file")
 	}
+	defer f.Close()
 
 	outputPath := fmt.Sprintf("%s/%d.tar.gz", appID, sequence)
 	err = filestore.GetStore().WriteArchive(outputPath, f)