exclude status informers before sending to operator (#906)

replicatedhq · Aug 4, 2020 · fddd027 · fddd027
1 parent 9fa8c74
commit fddd027
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/kotsadm/api/src/sockets/kots/DeploySocket.ts b/kotsadm/api/src/sockets/kots/DeploySocket.ts
@@ -308,6 +308,9 @@ export class KotsDeploySocketService {
                 for (let i = 0; i < kotsAppSpec.statusInformers.length; i++) {
                   const informer = kotsAppSpec.statusInformers[i];
                   const rendered = await kotsRenderFile(app, deployedAppSequence, informer, registryInfo);
+                  if (rendered === "") {
+                    continue;
+                  }
                   renderedInformers.push(rendered);
                 }
                 // send to kots operator

diff --git a/kotsadm/operator/pkg/client/client.go b/kotsadm/operator/pkg/client/client.go
@@ -415,9 +415,6 @@ func runPreflight(preflightURI string, ignorePermissions bool) error {
 func (c *Client) applyAppInformers(appID string, informerStrings []types.StatusInformerString) {
 	var informers []types.StatusInformer
 	for _, str := range informerStrings {
-		if str == "" {
-			continue
-		}
 		informer, err := str.Parse()
 		if err != nil {
 			log.Printf(fmt.Sprintf("failed to parse informer %s: %s", str, err.Error()))