Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move license API to Go #1003

Merged
merged 1 commit into from Aug 25, 2020
Merged

move license API to Go #1003

merged 1 commit into from Aug 25, 2020

Conversation

divolgin
Copy link
Member

@divolgin divolgin commented Aug 25, 2020 •
edited

Validated

  • fields with omitempty
  • expiration time format
  • value formatting for string vs numeric vs booleans

marccampbell
marccampbell approved these changes Aug 25, 2020
View reviewed changes
kotsadm/pkg/store/s3pg/s3pg_store.go
type S3PGStore struct {
}

func (s S3PGStore) IsNotFound(err error) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@divolgin divolgin merged commit b309f72 into master Aug 25, 2020
@divolgin divolgin deleted the divolgin/license-api branch August 25, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marccampbell marccampbell marccampbell approved these changes

@sgalsaleh sgalsaleh sgalsaleh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@divolgin @marccampbell @sgalsaleh