Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move createGitOpsRepo mutation to go #1004

Merged
merged 8 commits into from Aug 25, 2020
Merged

move createGitOpsRepo mutation to go #1004

merged 8 commits into from Aug 25, 2020

Conversation

sgalsaleh
Copy link
Member

No description provided.

GraysonNull
GraysonNull reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@GraysonNull GraysonNull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. I'd like to see some better error handling on these queries rather than just logging the errors. Just spent a bunch of time improving error handling across the app and we should avoid building up that debt again.

@sgalsaleh sgalsaleh merged commit 56740e1 into master Aug 25, 2020
@sgalsaleh sgalsaleh deleted the move-create-gitops-repo-to-go branch August 25, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marccampbell marccampbell marccampbell left review comments

@divolgin divolgin divolgin approved these changes

@GraysonNull GraysonNull GraysonNull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgalsaleh @marccampbell @divolgin @GraysonNull