Adding testing framework for rendering upstream to base #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[ch36201] |
sgalsaleh
approved these changes
Jul 28, 2021
divolgin
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fill a gap in KOTS test coverage. We have very little coverage of combinations of application yaml and upstream configuration.
Currently kots has unit tests and e2e tests. Unit tests for renderReplicated can cover the same but are cumbersome to write because they are in code. E2e tests also can cover this but are slow.
This adds a testing framework for testing kots rendering of upstream yaml to base yaml. To add tests, the developer must include yaml files in the directories upstream and base, which include input yaml and expected output yaml respectively.