Wait for the K8s api server to start #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
reviewed
Aug 4, 2021
| @@ -31,5 +33,8 @@ func runScheduler(ctx context.Context, dataDir string) error { | |||
| logger.Infof("kubernetes scheduler exited %v", command.Execute()) | |||
| }() | |||
|
|
|||
| time.Sleep(time.Second * 20) | |||
| wg.Done() | |||
There was a problem hiding this comment.
I think this is meant to be in the go func above. not sure using wait groups in synchronous code makes much sense
There was a problem hiding this comment.
oops, that sleep was debugging code, removed.
agreed on wait groups. should this be async and wgs, or all sync? any preference?
marccampbell
force-pushed
the
embedded-startup
branch
from
bf525a9
to
5bc1aee
Compare
divolgin
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will wait for the api server to start by polling it's readyz endpoint.
This is necessary to start controlling the startup and verifying that the cluster is ready before the app can be deployed.
Now, when starting the app with
kots runthe output is: