clearer preflight status' on version history rows #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GraysonNull
commented
Aug 6, 2021
•
GraysonNull
commented
| Checks bypassed, failed | Checks bypassed, passed with warnings |
|---|---|
|
|
sgalsaleh
reviewed
Aug 6, 2021
| const preflightState = getPreflightResultState(preflightResult); | ||
| preflightsFailed = preflightState === "fail"; | ||
| if (version.status === "pending") { | ||
| preflightState = getPreflightResultState(preflightResult); |
There was a problem hiding this comment.
this can be outside of the if statement since it's duplicated here https://github.com/replicatedhq/kots/pull/2055/files#diff-a5ee13382325550db7f0c09495c03715d7dbb7c581dfce6d03a32d0ee81360cdR129
There was a problem hiding this comment.
ah yeah good catch. Updated this logic a bit and didn't move that part out.
sgalsaleh
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.