Add pull request template #2161
Conversation
| If no, just write "NONE" in the release-note block below. | ||
| If yes, a release note is required: | ||
| --> | ||
| ```release-note |
There was a problem hiding this comment.
Do we ask for a link to a PR into kots.io? This is a lot to ask of an external contributor.
There was a problem hiding this comment.
I don't think so. Maybe we can ask that they supply a release note for the feature in the PR request and we can go through merged PRs and grab them when we release? It be awesome if we had a way of automating this step.
There was a problem hiding this comment.
Agreed. Automating should be next steps
emosbaugh
force-pushed
the
emosbaugh/sc-37099/pull_request_template
branch
from
b81382b
to
1cce199
Compare
| #### Does this PR require documentation? | ||
| <!-- | ||
| If no, just write "NONE" below. | ||
| If yes, link to the related https://github.com/replicatedhq/kots.io documentation PR: |
There was a problem hiding this comment.
I think it's reasonable to expect a kots.io pr from employees, but considering everyone that submits a PR may not be, how about we ask them to attach a markdown file containing the PR documentation to the PR request?
There was a problem hiding this comment.
Let's just see how it goes...
This PR includes a PR template to set some guidelines on contributing including release notes, documentation and testing.