-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify troubleshoot specs #2213
Unify troubleshoot specs #2213
Conversation
8837c53
to
df4473e
Compare
Below is the diff after this change: apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
creationTimestamp: null
name: default-supportbundle
spec:
analyzers: []
collectors:
- exec:
args:
- http://localhost:3030/goroutines
collectorName: kotsadm-operator-goroutines
command:
- curl
containerName: kotsadm-operator
exclude: ""
name: kots/admin_console
namespace: default
selector:
- app=kotsadm-operator
timeout: 10s
- copyFromHost:
collectorName: kurl-host-preflights
exclude: ""
extractArchive: true
hostPath: /var/lib/kurl/host-preflights
image: alpine
imagePullPolicy: IfNotPresent
name: kots/kurl/host-preflights
namespace: ""
timeout: 1m
- configMap:
collectorName: kurl-current-config
exclude: ""
includeAllData: true
name: kurl-current-config
namespace: kurl
- configMap:
collectorName: kurl-last-config
exclude: ""
includeAllData: true
name: kurl-last-config
namespace: kurl
- collectd:
collectorName: collectd
exclude: ""
hostPath: /var/lib/collectd/rrd
image: alpine
imagePullPolicy: IfNotPresent
namespace: ""
timeout: 5m |
@@ -95,6 +96,7 @@ spec: | |||
namespace: kurl | |||
- secret: | |||
collectorName: kotsadm-replicated-registry | |||
name: kotsadm-replicated-registry # TODO: what is the correct name here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the correct name for the secret used by kotsadm. app secret names are generated dynamically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i clarified this comment
What type of PR is this?
kind/chore
What this PR does / why we need it:
This PR is an attempt to streamline the process of writing new default collectors and analyzers by unifying the kots.io spec and the spec that is injected in go when generating a bundle through the KOTS UI. This code change makes it so that KOTS uses the kots.io spec in addition to the injected go spec and eliminates as much as possible from the go code.
Which issue(s) this PR fixes:
Fixes NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE