fix: append additional files correctly for sub charts #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningvera
requested review from
divolgin,
a team and
jeffreygolden
and removed request for
divolgin
|
the fix
|
sgalsaleh
approved these changes
Sep 25, 2021
divolgin
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/bug
What this PR does / why we need it:
This fixes an issue that was causing Chart.yaml and Chart.lock to be ignored for Helm sub-charts. With this fix, any level of sub-chart nesting should work now.
It still handles the special case where
base.Path == ""for the top-level Chart.yaml and Chart.lock. For sub-charts, it does a slightly different check to find the correct additional files. Previously those additional files were being ignored which led to a Helm error when deploying.Which issue(s) this PR fixes:
Fixes SH37929
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE