Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock one chart at a time for midstream #2244

Conversation

jeffreygolden
Copy link
Contributor

What type of PR is this?

kind/bug

What this PR does / why we need it:

When using the Beta Helm functions, charts were not getting a proper Kustomize file or PullSecrets file. The charts were being skipped by kustomize. This fixed a previous bug where subcharts were being targeted by parent level Kustomize files, causing a Kustomize error on deploy, but introduced this new regression where the charts weren't being kustomized at all.

This PR splits the difference. It prevents charts from being kustomized at the Common Midstream level. It also prevents subcharts from being kustomized at the parent chart level. Now, all Kustomize files target each chart discretely, at the appropriate directory level.

Special notes for your reviewer:

Added new comments in the code to prevent future confusion around the UseHelmInstall map. Please let me know if these comments can be clarified further.

Does this PR introduce a user-facing change?

Helm Charts should get the proper Kustomization for images and pull secrets at each chart level when using the beta Helm Install feature.

Does this PR require documentation?

NONE

@jeffreygolden
Copy link
Contributor Author

I've tested this with three licenses:

  1. no Helm charts (received the correct kustomization.yaml file in midstream)
  2. single chart, no subcharts (received the correct kustomization.yaml file in midstream/chart/chartname)
  3. parent chart with many nested subcharts (received kustomization.yaml files in each chart with only that chart's images listed)

@jeffreygolden jeffreygolden marked this pull request as ready for review October 13, 2021 19:26
@jeffreygolden jeffreygolden requested review from a team, divolgin and laverya October 13, 2021 19:26
@jeffreygolden jeffreygolden merged commit 9409f1e into master Oct 13, 2021
@jeffreygolden jeffreygolden deleted the jeffgolden/sc-38454/useHelmInstall-charts-not-getting-kustomized branch October 13, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants