Unblock one chart at a time for midstream #2244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/bug
What this PR does / why we need it:
When using the Beta Helm functions, charts were not getting a proper Kustomize file or PullSecrets file. The charts were being skipped by kustomize. This fixed a previous bug where subcharts were being targeted by parent level Kustomize files, causing a Kustomize error on deploy, but introduced this new regression where the charts weren't being kustomized at all.
This PR splits the difference. It prevents charts from being kustomized at the Common Midstream level. It also prevents subcharts from being kustomized at the parent chart level. Now, all Kustomize files target each chart discretely, at the appropriate directory level.
Special notes for your reviewer:
Added new comments in the code to prevent future confusion around the UseHelmInstall map. Please let me know if these comments can be clarified further.
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE