Jeffgolden/sc 38476/testing for kots pull #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2021 21:40
sgalsaleh
reviewed
Oct 15, 2021
sgalsaleh
reviewed
Oct 15, 2021
laverya
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/enhancement
What this PR does / why we need it:
We recently added a test suite for RenderUpstream. The design of this suite should be used against the Pull function to test both rendering and kustomization for an app. These tests will protect pull secrets, image rewrites, and Helm functionality in the Kots install process.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Does this PR require documentation?
NONE