Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail weave report if no files collected #2281

Merged
merged 1 commit into from Oct 29, 2021
Merged

Conversation

divolgin
Copy link
Member

What type of PR is this?

kind/enhancement

What this PR does / why we need it:

Do not show missing weave and goldpinger error when files are missing. These are kurl specific files and only present in kurl clusters.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed a bug that showed Weave and Inter-pod Networking errors when no corresponding data is collected because it is not applicable.

Does this PR require documentation?

NONE

@divolgin divolgin requested a review from a team October 29, 2021 19:07
Copy link

@label-checker label-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label type:: is required.

Copy link

@label-checker label-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label type:: is required.

@divolgin divolgin merged commit 6b7b6b5 into master Oct 29, 2021
@divolgin divolgin deleted the divolgin/expired branch October 29, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants