38977: Fix analysis filtering #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntastical
force-pushed
the
fix-analysis-filtering
branch
from
0ad95c4
to
f22d9ad
Compare
sgalsaleh
reviewed
Nov 2, 2021
| } | ||
|
|
||
| this.checkBundleStatus(); | ||
| } | ||
|
|
||
| checkBundleStatus = () => { | ||
| checkBundleStatus() { |
There was a problem hiding this comment.
why? es6 syntax auto binds the function to the context
sgalsaleh
reviewed
Nov 2, 2021
| let nextState = {}; | ||
| const val = e.target.checked ? "1" : "0"; | ||
| nextState[field] = val; | ||
| handleFilterTiles(checked) { |
There was a problem hiding this comment.
same, we should keep the es6 syntax
syntastical
force-pushed
the
fix-analysis-filtering
branch
from
f22d9ad
to
5955bfe
Compare
sgalsaleh
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix frontend filtering logic to match the text displayed to the user.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE